[SYCL][E2E] DX12 Bindless Image Interop tests #21432
Conversation
…but want to see where exactly.
YuriPlyakhin
left a comment
There was a problem hiding this comment.
change in sycl/test-e2e/SpecConstants/2020/native_specialization_constant.cpp lgtm
|
@slawekptak - can you review on behalf of llvm-reviewers-runtime? |
There was a problem hiding this comment.
Just to make sure - the "buffer" and "buffer_binary_semaphore" tests don't apply to DX12?
There was a problem hiding this comment.
I'm not sure I understand this comment.
The -ld3d12 flag when compiling ensures it's DX12.
There was a problem hiding this comment.
The vulkan_interop test directory contains the following buffer-related tests: vulkan_sycl_buffer_timeline_semaphore.cpp, vulkan_sycl_buffer_binary_semaphore.cpp and vulkan_sycl_buffer.cpp. This PR only adds the one related to timeline semaphore. If the DX12 tests reflect the vulkan test structure, I was wondering if the other two should also be added here, or they just don't apply to DX12.
There was a problem hiding this comment.
DX12 only has timeline semaphore, not binary. The timeline semaphore test has a --no-sem pass which serves as a base "buffer interop" test.
|
Hmm. Made a mistake with GTA. But on BMG these tests pass with the older L0 driver. And they pass with the latest L0 Driver. But the CI, which has Older Driver Testing Time: 54.77s Total Discovered Tests: 8 1 warning(s) in tests Newer Driver: Testing Time: 71.21s Total Discovered Tests: 8 1 warning(s) in tests Hmm - works on BMG with same driver. |
|
@intel/llvm-gatekeepers please consider merging |
New tests for DX12 bindless image support. Mirroring the same general structure as we are using on the Vulkan ones.