🐛 Fix formatting an enum without an identifier #309
Merged
+32
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
- Formatting an enumeration value does not work when the enumeration value has
no identifier. e.g.
```cpp
enum struct E{};
constexpr auto s = stdx::enum_as_string<E{17}>(); // should be something like "(E)17"
```
Solution:
- Allow `enum_as_string` to take account of "cast-style" compiler representation
when enumeration values don't have identifiers.
elbeno
force-pushed
the
fix-unidentified-enum-format
branch
from
e34ae2b to
bb3fcbf
Compare
lukevalenty
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
enum_as_stringto take account of "cast-style" compiler representation when enumeration values don't have identifiers.