Sage fast sfm#1843
Merged
Merged
Conversation
luoyu-intel
force-pushed
the
sage_fast_sfm
branch
2 times, most recently
from
d8644ba to
370a957
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates SAGEv1 SDPA benchmarking and optimizes parts of the SAGEv1 forward softmax path using SIMD32-packed inline vISA assembly helpers.
Changes:
- Added new SAGEv1 accuracy case and expanded benchmarks, including an int8(Q/K)+pvhalf(V) kernel benchmark path.
- Added dynamic quantization + scale buffers to support benchmarking
sdpa_impl_qks8_pvhalf. - Introduced SIMD32 “pairwise” inline-assembly helpers and used them in the softmax step to reduce instruction count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| auto_round_extension/ark/auto_round_kernel/wrapper/test/test_sdpa.hpp | Extends tests/benchmarks to include causal accuracy coverage and an additional int8(Q/K) kernel benchmark path (with dynamic quant + scale buffers). |
| auto_round_extension/ark/auto_round_kernel/wrapper/include/stla/xe_sagev1_fwd_mainloop.hpp | Adds SIMD32-packed inline assembly helpers (exp/max/mul/add) and integrates them into softmax to speed up per-row max/rescale and exponentiation. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~5% performance speedup， 95TOPS->100TOPS