Fix some CI issues#1842
Open
lvliang-intel wants to merge 9 commits into
Open
Conversation
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR addresses CI failures by making model path resolution in tests more robust, hardening GGUF export conversion against missing model attributes, and refining GGUF-format detection / ignore-layer handling in the compressor layer config logic.
Changes:
- Update GGUF export test to resolve the model via a helper path resolver.
- Guard GGUF tensor conversion against missing
_checkpoint_conversion_mapping. - Refine GGUF format detection and adjust ignore-layer preprocessing in
configure_layer_config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/test_cpu/export/test_gguf_format.py | Uses a model-path helper for more reliable CI execution. |
| auto_round/export/export_to_gguf/convert.py | Avoids attribute errors when conversion mapping is absent. |
| auto_round/compressors/base.py | Updates GGUF format detection and ignore-layer preprocessing logic. |
| cls.model.tensor_name_list = [] | ||
|
|
||
| reverse_key_mapping = {v: k for k, v in cls.model._checkpoint_conversion_mapping.items()} | ||
| reverse_key_mapping = {v: k for k, v in getattr(cls.model, "_checkpoint_conversion_mapping", {}).items()} |
| is_gguf_format = (f := getattr(self.compress_context, "formats", None)) is not None and "gguf" in f | ||
| _formats = getattr(self.compress_context, "formats", None) | ||
| is_gguf_format = _formats is not None and any( | ||
| "gguf" in str(getattr(fmt, "output_format", "")) for fmt in _formats |
Comment on lines
563
to
+577
| predefined_ignore_layers = get_predefined_ignore_layers(self.model_context.model) | ||
| compressed_predefined_ignore_layers = compress_layer_names(predefined_ignore_layers) | ||
| if not is_gguf_format: | ||
| predefined_ignore_layers = get_predefined_ignore_layers(self.model_context.model) | ||
| if predefined_ignore_layers and self.quant_block_list: | ||
| block_prefixes = [block for group in self.quant_block_list for block in group] | ||
| predefined_ignore_layers = [ | ||
| name | ||
| for name in predefined_ignore_layers | ||
| if any(name.startswith(prefix) for prefix in block_prefixes) | ||
| ] | ||
| predefined_ignore_layers = compress_layer_names(predefined_ignore_layers) | ||
| if predefined_ignore_layers: | ||
| logger.info(f"Using predefined ignore_layers: {compressed_predefined_ignore_layers}") | ||
| tmp_str = ",".join(predefined_ignore_layers) | ||
| tmp_str = predefined_ignore_layers.replace(" ", "") |
… into lvl/fix_ci_issues
for more information, see https://pre-commit.ci
… into lvl/fix_ci_issues Signed-off-by: lvliang-intel <liang1.lv@intel.com>
… into lvl/fix_ci_issues
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix some CI issues:
https://dev.azure.com/lpot-inc/b7121868-d73a-4794-90c1-23135f974d09/_apis/build/builds/63619/logs/68
https://dev.azure.com/lpot-inc/b7121868-d73a-4794-90c1-23135f974d09/_apis/build/builds/63619/logs/62
https://dev.azure.com/lpot-inc/b7121868-d73a-4794-90c1-23135f974d09/_apis/build/builds/63619/logs/76
Type of Change
Bug fix
Related Issues
Fixes or relates to #
Checklist Before Submitting
/azp run Unit-Test-CUDA-AutoRound.