fix merge error of llmc bug#1817
Open
n1ck-guo wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
Signed-off-by: n1ck-guo <heng.guo@intel.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR fixes a merge-related bug in DataDrivenCompressor.quantize_block by allowing it to run for MLLM models (while still blocking diffusion), and adds a CPU unit test to prevent regressions.
Changes:
- Relaxed
quantize_blockguard to only reject diffusion models (no longer rejects MLLM). - Added a CPU test ensuring
quantize_blockworks for MLLM and thatis_mllmis restored after preprocessing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/test_cpu/core/test_llmc_quantize_block.py | Adds regression test verifying MLLM is allowed and is_mllm is restored after quantize_block. |
| auto_round/compressors/data_driven.py | Updates model-type guard to reject only diffusion models. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe your main changes, the motivation.
Type of Change
Bug fix
Related Issues
Fixes or relates to #
Checklist Before Submitting
/azp run Unit-Test-CUDA-AutoRound.