Fix forwarding of ExtraConfig overrides#1816
Open
dhruvil237 wants to merge 1 commit into
Open
Conversation
f7c03ce to
9c23c98
Compare
Signed-off-by: Dhruvil Patel <76389644+dhruvil237@users.noreply.github.com>
9c23c98 to
299879e
Compare
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Commenter does not have sufficient privileges for PR 1816 in repo intel/auto-round |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a constructor-path bug where
ExtraConfigscheme overrides were dropped before reachingAutoRoundCompatible.When the old
AutoRoundAPI is used withextra_config=ExtraConfig(...),autoround.pyonly merged fields that already existed inlocal_args. Fields that the new architecture expects throughkwargs, such asbitsandgroup_size, were silently lost. As a result, preset scheme defaults could override explicit user settings.This change preserves the existing
local_argsbehavior and also forwards non-localExtraConfigvalues into the entrypoint kwargs, while still letting explicit kwargs win if both are provided.A regression test was added to cover the failing path.
Type of Change
Bug fix
Related Issues
Fixes or relates to #
Checklist Before Submitting
/azp run Unit-Test-CUDA-AutoRound.Local Validation
mainthatextra_config=ExtraConfig(group_size=32, bits=4)reachedAutoRoundCompatiblewithoutgroup_sizeorbits.group_size=32andbits=4correctly.pytestis not installed in this environment, so the repo test suite was not run here.