Skip to content

Fix forwarding of ExtraConfig overrides#1816

Open
dhruvil237 wants to merge 1 commit into
intel:mainfrom
dhruvil237:fix/forward-extra-config-overrides
Open

Fix forwarding of ExtraConfig overrides#1816
dhruvil237 wants to merge 1 commit into
intel:mainfrom
dhruvil237:fix/forward-extra-config-overrides

Conversation

@dhruvil237
Copy link
Copy Markdown

Description

This fixes a constructor-path bug where ExtraConfig scheme overrides were dropped before reaching AutoRoundCompatible.

When the old AutoRound API is used with extra_config=ExtraConfig(...), autoround.py only merged fields that already existed in local_args. Fields that the new architecture expects through kwargs, such as bits and group_size, were silently lost. As a result, preset scheme defaults could override explicit user settings.

This change preserves the existing local_args behavior and also forwards non-local ExtraConfig values into the entrypoint kwargs, while still letting explicit kwargs win if both are provided.

A regression test was added to cover the failing path.

Type of Change

Bug fix

Related Issues

Fixes or relates to #

Checklist Before Submitting

  • My code has been tested locally.
  • Documentation has been updated as needed.
  • New or updated tests are included where applicable.
  • The CUDA CI has passed. You can trigger it by commenting /azp run Unit-Test-CUDA-AutoRound.

Local Validation

  • Reproduced on current main that extra_config=ExtraConfig(group_size=32, bits=4) reached AutoRoundCompatible without group_size or bits.
  • Verified after the fix that the same path forwards group_size=32 and bits=4 correctly.
  • pytest is not installed in this environment, so the repo test suite was not run here.

@dhruvil237 dhruvil237 force-pushed the fix/forward-extra-config-overrides branch from f7c03ce to 9c23c98 Compare May 14, 2026 06:36
Signed-off-by: Dhruvil Patel <76389644+dhruvil237@users.noreply.github.com>
@dhruvil237 dhruvil237 force-pushed the fix/forward-extra-config-overrides branch from 9c23c98 to 299879e Compare May 14, 2026 06:37
@dhruvil237
Copy link
Copy Markdown
Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 1816 in repo intel/auto-round

@wenhuach21 wenhuach21 added this to the 0.13.0 milestone May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants