feat(credential-requests): Add new credential requests endpoints#40
Open
Bram Winter (winterworks) wants to merge 3 commits intomainfrom
Open
feat(credential-requests): Add new credential requests endpoints#40Bram Winter (winterworks) wants to merge 3 commits intomainfrom
Bram Winter (winterworks) wants to merge 3 commits intomainfrom
Conversation
…uest endpoints with name and description support
Bram Winter (winterworks)
changed the title
…ial request endpoint
Bram Winter (winterworks)
changed the title
Bram Winter (winterworks)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SDK’s credential-requests surface to match new API capabilities by adding “create-by-credentials” and “extend connection” actions, and removing the deprecated “get credential” endpoint, with corresponding unit/integration test and MCP tool updates.
Changes:
- Added SDK methods/types for
createByCredentialsandextendConnection, plusnameOverridesupport on returned credentials. - Removed the SDK/MCP “get credential” functionality and related test mocks/tests.
- Updated and expanded unit + integration tests and added new response mocks.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/retry.spec.ts | Formatting updates to retry tests. |
| test/mocks/credential-requests/get-credential.json | Removed mock for removed getCredential endpoint. |
| test/mocks/credential-requests/extend-connection.json | Added mock response for extend-connection action. |
| test/mocks/credential-requests/create-by-credentials.json | Added mock response for create-by-credentials action. |
| test/make.spec.ts | Minor formatting fix. |
| test/credential-requests.spec.ts | Removed getCredential tests; added tests for new endpoints; updated createAction payloads. |
| test/credential-requests.integration.test.ts | Removed remote credential fetch flow; added integration coverage for new endpoints and name/description support. |
| src/index.ts | Re-exported new public endpoint types. |
| src/endpoints/credential-requests.ts | Added new request-body types + new SDK methods; removed getCredential; added nameOverride field on Credential. |
| src/endpoints/credential-requests.mcp.ts | Removed credential_get tool; expanded create tool schema; added MCP tools for create-by-credentials and extend-connection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+264
to
+268
| type: 'array', | ||
| description: | ||
| 'Array of OAuth or basic-auth connections to request. Each item needs at least a "type" (e.g. "google", "slack", "github").', | ||
| maxItems: 32, | ||
| items: { |
| type: 'array', | ||
| description: | ||
| 'One or more new OAuth scope strings to add to the connection. At least one scope must be new (not already granted).', | ||
| minItems: 1, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr updated the credential request endpoints: