refactor(credential-requests): rename and simplify credential request endpoints#37
Merged
Patrik Simek (patriksimek) merged 6 commits intomainfrom Mar 10, 2026
Merged
Conversation
…and enhance documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MCP tool definitions for the credential requests endpoint. It consolidates the API surface by removing the low-level "create credential request" MCP tool and replacing it with the simpler createAction flow. The PR also renames several tools for brevity and improves tool descriptions with more contextual guidance.
Changes:
- Removes the
credential_requests_createMCP tool (which calledcreate) and promotescreateActionas the primary way to create credential requests via MCP (now namedcredential_requests_create) - Renames credential-level tools from
credential_requests_get_credential/decline/delete_credentialto shorter forms (credential_get/decline/delete) and introduces a newCredentialSelectiontype for the simplifiedCreateCredentialActionBody - Updates tests to reflect the new
credentialsarray field (replacingconnections/keys) andappVersionas anumberinstead ofstring
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/endpoints/credential-requests.ts |
Introduces CredentialSelection type and simplifies CreateCredentialActionBody to use a single credentials array |
src/endpoints/credential-requests.mcp.ts |
Renames and extends descriptions for MCP tools; removes old create tool; adds new detailed schema for credential_requests_create |
src/index.ts |
Exports new CreateCredentialActionBody and CredentialSelection types |
test/credential-requests.spec.ts |
Updates createAction test to use the new credentials field with appVersion as a number |
test/credential-requests.integration.test.ts |
Updates integration tests to use getDetail directly and new createAction body shape |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rity and consistency
YoadBarok
approved these changes
Mar 10, 2026
Patrik Simek (patriksimek)
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the MCP tools for credential requests: