fix: add nil check for ref_name element in expandConditions#3300
Open
majiayu000 wants to merge 2 commits intointegrations:mainfrom
Open
fix: add nil check for ref_name element in expandConditions#3300majiayu000 wants to merge 2 commits intointegrations:mainfrom
majiayu000 wants to merge 2 commits intointegrations:mainfrom
Conversation
When creating an org ruleset without ref_name specified, Terraform
passes []any{nil} which passes existing length checks but panics
at the type assertion on line 194. Add v[0] != nil guard.
Fixes integrations#3299
Signed-off-by: majiayu000 <1835304752@qq.com>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Address review feedback on PR integrations#3300: refactor the single TestExpandConditions_NilRefName test into a table-driven TestExpandConditions with broader coverage. Signed-off-by: majiayu000 <1835304752@qq.com>
deiga
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v[0] != nilguard to theref_namecondition check inexpandConditions(util_rules.go:193) to prevent a panic whenref_namecontains a nil element (e.g. org rulesets withoutref_namespecified)TestExpandConditions_NilRefNameverifying no panic and nil RefName resultFixes #3299
Test plan
TestExpandConditions_NilRefNamepasses — confirms no panic on[]any{nil}inputgo test ./github/... -skip '^TestAcc')go build ./...)