feat: Adding github_enterprise_ip_allow_list_entry resource#2649
feat: Adding github_enterprise_ip_allow_list_entry resource#2649ErikElkins wants to merge 33 commits intointegrations:mainfrom
Conversation
ErikElkins
changed the title
|
@ErikElkins Apologies for the delay on getting to this PR. Would you be willing to fix the lint issue? Thank you! |
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
Is there a REST API for this functionality?
github-project-automation
bot
moved this from 👀 In review
to 🏗 In progress
in 🧰 Octokit Active
|
Yep! Let me jump in here. |
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
|
Oh, i see the other PR. Should we just close this? EDIT: NEVERMIND |
Doesn't look like they've added it since I opened the PR. |
gateixeira
left a comment
gateixeira
left a comment
There was a problem hiding this comment.
hi @ErikElkins 👋
I was updating your PR to have the lint fixed and realized that the acceptance tests seem to also not pass. Can you please update the PR with the following? Feel free to validate on your end.
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
gateixeira
left a comment
gateixeira
left a comment
There was a problem hiding this comment.
@ErikElkins thanks for the changes!
|
@ErikElkins could you please rebase? |
|
@deiga are you happy with this now? If so could you please approve (or clear your requested changes)? |
|
@ErikElkins Would you be available to rebase and test this again? :) |
Merged and tested, looks good! |
6 participants
Resolves #2648
Before the change?
After the change?
github_enterprise_ip_allow_list_entryresource.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!