Open
Conversation
The hash() function exported from @instructure/ui-utils has no internal callers — only its own test imports it. Drop the module, its test, the export from the package index, and the json-stable-stringify dependency that existed solely to support it.
|
matyasf
requested changes
May 6, 2026
| export { cloneArray } from './cloneArray' | ||
| export { createChainedFunction } from './createChainedFunction' | ||
| export { deepEqual } from './deepEqual' | ||
| export { hash } from './hash' |
Collaborator
There was a problem hiding this comment.
This might be used by others, please do not remove it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash()exported from@instructure/ui-utilshas no internal callers — the only importer in the repo is its own testpackages/ui-utils/src/hash.ts, its test, the re-export fromsrc/index.ts, and thejson-stable-stringifydependency that existed solely to back itTest plan
pnpm installresolves cleanlypnpm run build:typessucceedspnpm run test:vitest ui-utilspassespnpm run test:vitestpasses