Open
Conversation
Drop dependency declarations that are not imported anywhere in source: - docs-app: buffer, marked, semver (marked-react pulls marked transitively; buffer/semver had no import sites) - ui-date-input: moment-timezone (the Moment type flows in via @instructure/ui-i18n; nothing imports moment-timezone directly) - ui-scripts: mocha (residual from the legacy ui-test --mocha flow; vitest is the test runner)
|
matyasf
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop dependency declarations that are not imported anywhere in source:
buffer,marked,semver(marked-reactpullsmarkedtransitively; no import sites forbuffer/semver)moment-timezone(theMomenttype flows in via@instructure/ui-i18n; nothing importsmoment-timezonedirectly)mocha(residual from the legacyui-test --mochaflow;vitestis the test runner)Test plan
pnpm installresolves cleanlypnpm run build:typessucceedspnpm run test:vitestpassespnpm run dev)