Open
Conversation
|
HerrTopi
force-pushed
the
custom-component-theming
branch
from
48b1e3f to
1d40756
Compare
HerrTopi
force-pushed
the
custom-component-theming
branch
from
1d40756 to
ad47fc5
Compare
… definition so they can build their own components with InstUI
HerrTopi
force-pushed
the
custom-component-theming
branch
from
9147b01 to
74c76a5
Compare
matyasf
reviewed
May 6, 2026
|
|
||
| ## [11.7.2](https://github.com/instructure/instructure-ui/compare/v11.7.1...v11.7.2) (2026-04-23) | ||
|
|
||
|
|
matyasf
reviewed
May 6, 2026
Comment on lines
+10
to
+18
| - **many:** small fixes for doc and fix component directory mapping in "dev" script ([39f0c99](https://github.com/instructure/instructure-ui/commit/39f0c991315e39d30e1f24b3142b986d5b9041ee)) | ||
|
|
||
| ### Features | ||
|
|
||
| * **ui,ui-options,ui-drilldown:** rework Drilldown ([0562fe2](https://github.com/instructure/instructure-ui/commit/0562fe2b43e3235fc78c4981ada504c1a2f10d1a)) | ||
|
|
||
| - **ui,ui-options,ui-drilldown:** rework Drilldown ([0562fe2](https://github.com/instructure/instructure-ui/commit/0562fe2b43e3235fc78c4981ada504c1a2f10d1a)) | ||
|
|
||
| ### BREAKING CHANGES | ||
|
|
||
| * **ui,ui-options,ui-drilldown:** the component got a new version in this release | ||
| - **ui,ui-options,ui-drilldown:** the component got a new version in this release |
Collaborator
There was a problem hiding this comment.
Why are there these changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables consumers to build their own components on top of InstUI's new theming system by passing a
generateComponentThemefunction directly touseStyleNew/withStyleNew, instead of requiring the component theme to be pre-registered in the theme object.useStyleNewandwithStyleNewnow accept an optionalgenerateComponentThemeparameter. When provided, it receives{ primitives, semantics, sharedTokens }and returns the component theme — so consumer-authored components can derive their own tokens from InstUI's theming primitives without modifying the theme.useStyleLegacy→useStyle(kept stable for old-theme consumers)useStyle(new theming) →useStyleNewwithStyleLegacy→withStylewithStyle(new theming) →withStyleNewuseStyleNew.Test plan
pnpm run dev, open the docs app, and spot-check a few v2 components (e.g. Avatar, Button, RadioInput, TextInput, Tooltip, View) — they render correctly under the default theme and respectthemeOverrideviaInstUISettingsProviderand prop-level overridesuseStyleNewwith its owngenerateComponentTheme(pass a component theme to any component to try) and confirm that:themeOverrideprop andInstUISettingsProvidercomponentsoverrides are applied on top of the consumer-provided base themeuseStyleLegacy → useStyle/withStyleLegacy → withStylerename