fix(ui-date-input): add scrollbar to dateinput v2#2520
Open
joyenjoyer wants to merge 1 commit intomasterfrom
Open
fix(ui-date-input): add scrollbar to dateinput v2#2520joyenjoyer wants to merge 1 commit intomasterfrom
joyenjoyer wants to merge 1 commit intomasterfrom
Conversation
joyenjoyer
force-pushed
the
dateinput_popover_fix
branch
from
344a7d2 to
9f9c72e
Compare
|
Contributor
@joyenjoyer There is some issue around the corner (it is especially visible in the light theme), which is not present in the 11.7 master. |
Contributor
Screen.Recording.2026-04-21.at.13.38.49.mov@joyenjoyer When the Calendar is open and I scroll up and down a scrollbar appears when I think it should not (see the video) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4999
This PR adds a scrollbar to DateInput v2, it uses Balazs' nested rAF ColorPicker technique as an inspiration.
Test:
Open the docs page, open DateInput v2 (use the v11.7 switch), Zoom in at least 200% and observe if a scrollbar appears in DateInput.