fix(ui-motion): use elementRef instead of ref in BaseTransition renderChildren#2514
Open
fix(ui-motion): use elementRef instead of ref in BaseTransition renderChildren#2514
Conversation
|
|
|
Gazuru
force-pushed
the
LX-4014-fix-ref-is-not-a-prop
branch
from
6464e5e to
83e995a
Compare
…rChildren Replace the deprecated ref callback with elementRef and remove the now-redundant findDOMNode wrapper, since elementRef receives the DOM element directly from InstUI children. renderChildren now distinguishes between HTML elements and components: HTML elements receive a ref callback (which gives the DOM element directly), while components receive elementRef (the InstUI convention). This removes findDOMNode without breaking non-InstUI children like plain <div> or <span>. The test's ExampleComponent was updated from a class component to a functional component that supports elementRef.
Gazuru
force-pushed
the
LX-4014-fix-ref-is-not-a-prop
branch
from
83e995a to
bc37bd6
Compare
joyenjoyer
reviewed
Apr 21, 2026
| if (!this.props.children) return null | ||
|
|
||
| const child = ensureSingleChild(this.props.children) as ReactElement | ||
| const isInstUIComponent = !!(child.type as any)?.componentId |
Contributor
There was a problem hiding this comment.
Not all components have componentId, I believe this is not a reliable way to check if it is an InstUI component or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated ref callback with elementRef and remove the now-redundant findDOMNode wrapper, since elementRef receives the DOM element directly from InstUI children.
renderChildrennow distinguishes between HTML elements and components: HTML elements receive a ref callback (which gives the DOM element directly), while components receive elementRef (the InstUI convention). This removes findDOMNode without breaking non-InstUI children like plain<div>or<span>. The test's ExampleComponent was updated from a class component to a functional component that supports elementRef.Fixes LX-4024.