Conversation
|
I could definitely use this too! |
michaelbrewerdavis
requested changes
Sep 21, 2017
Collaborator
michaelbrewerdavis
left a comment
michaelbrewerdavis
left a comment
There was a problem hiding this comment.
Nice addition
| * Signature: | ||
| * | ||
| * ```js | ||
| * function(userInput){} |
Collaborator
There was a problem hiding this comment.
These would not be userInput, but the focus/blur events.
There was a problem hiding this comment.
handleInputFocus: function() {
this.props.onFocus();
this.maybeShowList();
},This is not receiving or passing the focus event. I'm using onBlur to do error handling. So it is required for the event to be passed into this.props.onBlur(). To keep it consistent, the onFocus code should probably be something like the following?
handleInputFocus: function(event) {
this.props.onFocus(event);
this.maybeShowList();
},
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR (#40) introduced an
onFocusprop, which was cool, but it would be helpful if we could handleblurtoo!