test: add regression tests for OTel context-stack corruption#517
Merged
Conversation
Add test/instrumentation/otel_context_leak_test.rb covering five instrumentation paths that previously left a non-SpanContext object as the of a non-recording span, causing NoMethodError on the next start_span call on the same thread. Each test is named after the component and observable behaviour rather than an opaque scenario letter, so failures are self-describing in CI output. Tests are written against the expected fixed behaviour and are intended to be merged before the corresponding source fixes land, serving as executable acceptance criteria. Covered paths: - Rack: context token not detached when agent is down (rack.rb) - rest-client: explicit with_parent on poisoned stack (rest-client.rb) - net-http: implicit Context.current fallback, both guard paths (net-http.rb) - gRPC: corrupted parent_context passed directly as with_parent (grpc.rb) - ActionCable: context stored from Rack-poisoned thread (action_cable.rb) Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
prevent-otel-context-leak
branch
from
082fecc to
6a933d9
Compare
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
prevent-otel-context-leak
branch
from
f3c6252 to
73c4aac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test/instrumentation/otel_context_leak_test.rb covering five instrumentation paths that previously left a non-SpanContext object as the of a non-recording span, causing NoMethodError on the next start_span call on the same thread.
Each test is named after the component and observable behaviour rather than an opaque scenario letter, so failures are self-describing in CI output.
Tests are written against the expected fixed behaviour and are intended to be merged before the corresponding source fixes land, serving as executable acceptance criteria.
Covered paths: