Open
Conversation
- teal_transform_module to not use badge_dropdown
This was referenced Oct 30, 2025
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: 1bed0b1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 32 suites 2m 28s ⏱️ For more details on these errors, see this check. Results for commit cefc62c. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 4c31502 ♻️ This comment has been updated with latest results. |
This was referenced Oct 31, 2025
Collaborator
|
8 failed tests in R CMD CHECK Error in `testthat::test_that("e2e: validate_input validates dateRangeInput")`: argument "code" is missing, with no defaultdoes |
Collaborator
|
Ah ok, those are those 8 tests that do not have any body yet |
Contributor
Author
Yup, this is for the first volunteer |
averissimo
reviewed
Apr 2, 2026
Comment on lines
-1
to
-23
| // This file contains functions that should be executed at the start of each session, | ||
| // not included in the original HTML | ||
|
|
||
| shinyjs.autoFocusModal = function(id) { | ||
| document.getElementById('shiny-modal').addEventListener( | ||
| 'shown.bs.modal', | ||
| () => document.getElementById(id).focus(), | ||
| { once: true } | ||
| ); | ||
| } | ||
|
|
||
| shinyjs.enterToSubmit = function(id, submit_id) { | ||
| document.getElementById('shiny-modal').addEventListener( | ||
| 'shown.bs.modal', | ||
| () => document.getElementById(id).addEventListener('keyup', (e) => { | ||
| if (e.key === 'Enter') { | ||
| e.preventDefault(); // prevent form submission | ||
| document.getElementById(submit_id).click(); | ||
| } | ||
| }) | ||
| ); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
@gogonzo why did you remove this? it's being used by the snapshot manager
Contributor
Author
There was a problem hiding this comment.
@averissimo I've made a mistake. I'll bring it back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes insightsengineering/NEST-roadmap#36
Check also with:
Introduces
validate_inputas an alternative toshinyvalidatepackage. Function is easier to handle thanshinyvalidate, as one can usevalidate_input()inreactiveand display-validation-error on the input and throw shiny-validate-error in the same time. See tmg PR to see how it works