Open
Conversation
Contributor
|
This is 100% on top of head, but I thought the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the core package, a key pair is generated without the
extractableparameter and then is exported usingexportJWK.According to the documentation (node, browser), this shouldn't be possible and I was getting a error saying "non-extractable CryptoKey cannot be exported as a JWK". Then I wondered how this ever worked in the first place... Apparently, running this with node doesn't throw an error, but I was using bun which does.
In this case, it seems like the incorrect behaviour is Node's, so we should be using the
extractableconfig. Just to made sure, I verified that my fix works in both runtimes.