Feat/device setup#1409
Draft
marcosinigaglia wants to merge 4 commits into
Draft
Conversation
Contributor
|
Hey whats left for this PR be approved? |
Member
Author
Hi, It's not complete and I don't have time now. Also I'm not convinced it's the right solution, the mechanisms are different, and it might be better to keep them separate by platform. |
Contributor
|
I had an pr that implement that
Em qui., 28 de mai. de 2026 às 05:26, Marco Sinigaglia <
***@***.***> escreveu:
… *marcosinigaglia* left a comment (innoveit/react-native-ble-manager#1409)
<#1409 (comment)>
Hey whats left for this PR be approved?
Hi, It's not complete and I don't have time now. Also I'm not convinced
it's the right solution, the mechanisms are different, and it might be
better to keep them separate by platform.
—
Reply to this email directly, view it on GitHub
<#1409?email_source=notifications&email_token=AG5NZ474BNGKV6GDUNEWRV3447Z35A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJWGIYDSNZWGQ4KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4562097648>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5NZ452R3526MDQMN4X2HT447Z35AVCNFSM6AAAAACZPXJBX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKNRSGA4TONRUHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
I can help you with that, we just need to agree on unified api for both platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a broad renaming and refactoring of the "companion" device setup feature across both Android and iOS platforms, standardizing terminology to "device setup" and improving code robustness and clarity. It also updates the example app to use the new APIs, enhances Bluetooth scanning logic, and adds iOS 18 AccessorySetupKit support for device setup. Below are the most important changes grouped by theme:
API and Naming Standardization:
BleManager.java,CompanionScanner.java) and iOS (BleManager.h,BleManager.mm,SwiftBleManager.swift), including exported methods likecompanionScan→deviceSetupScan,supportsCompanion→supportsDeviceSetup, and related event emitters. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]iOS Device Setup Support:
ASAccessory, and session management for accessory setup flows inSwiftBleManager.swift. [1] [2]Android Robustness Improvements:
CompanionScanner.javaby usingObjects.requireNonNulland checking for nulls before accessing values. [1] [2] [3]Example App Updates:
iOS Permissions:
app.config.jsfor iOS 18 compatibility.