Skip to content

cold: unified handle architecture (supersedes #57) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prestwich merged 19 commits into from
May 4, 2026
Merged

cold: unified handle architecture (supersedes #57) #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b539c8f
refactor(cold): ColdStorageWrite takes &self; all backends updated in…
prestwich Apr 21, 2026
31e1c13
refactor(cold): unify handle around Arc<Inner>; remove channels and d…
prestwich Apr 21, 2026
b0d3063
fix(cold): stream permit acquired in handle; streams do not hold a re…
prestwich Apr 21, 2026
9881f03
feat(cold): drain barrier moves to handle write path
prestwich Apr 21, 2026
9426d88
feat(cold): shutdown coordinator closes semaphores on cancel
prestwich Apr 21, 2026
902aab6
refactor(cold-mdbx): spawn_blocking reads, block_in_place writes, in-…
prestwich Apr 21, 2026
727c054
feat(cold-sql): mandatory statement_timeout; read_timeout and write_t…
prestwich Apr 21, 2026
978e2af
feat(cold): metrics and tracing spans across all operations
prestwich Apr 21, 2026
3339c87
docs(cold): trait impl guide documents mandatory timeouts
prestwich Apr 21, 2026
cb06741
test(cold): concurrency suite covers new architecture
prestwich Apr 21, 2026
25b4b6c
fix(cold): shutdown coordinator holds Weak<Inner>, not Arc
prestwich Apr 22, 2026
09c2981
fix(cold-mdbx): preserve TooManyLogs via From impl, not backend wrapper
prestwich Apr 22, 2026
4f67ca7
fix(cold): address review on permits, gauges, errors, cache
prestwich Apr 24, 2026
7c9d50a
fix(cold-mdbx): spawn_blocking writes, per-item deadlines, docs
prestwich Apr 24, 2026
0b965bf
docs(storage): align unified::drain_above doc with silent-swallow impl
prestwich Apr 30, 2026
d3e3210
fix(cold-sql): map PG statement_timeout to DeadlineExceeded
prestwich Apr 30, 2026
f5fdaae
feat(cold): hoist write SLO and stream-setup timeout into the handle
prestwich Apr 30, 2026
e6d44e4
fix(cold): reject zero timeouts; log JoinError panics; misc nits
prestwich Apr 30, 2026
36d1ace
test(cold): stream_logs setup fails fast on hung get_latest_block
prestwich Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .claude/skills/signet-storage/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,9 @@ ColdStorageReadHandle -- Read-only handle
- **`HistoryError<E>`** -- `NonContiguousBlock`, `ParentHashMismatch`,
`DbNotEmpty`, `EmptyRange`, `NoBlocks`, `HeightOutOfRange`, `Db(E)`,
`IntList`.
- **`ColdStorageError`** -- `Backend(E)`, `NotFound`, `Cancelled`,
`Backpressure`, `TaskTerminated`.
- **`ColdStorageError`** -- `Backend(E)`, `NotFound`, `TooManyLogs`,
`DeadlineExceeded`, `StreamDeadlineExceeded`, `ReorgDetected`,
`TaskTerminated`.
- **`StorageError`** -- `Hot(HistoryError<HotKvError>)` |
`Cold(ColdStorageError)`.

Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ indexed by block. Uses task-based async pattern with handles.

## Key Traits

- `ColdStorage`: Backend interface for cold storage
- `ColdStorageBackend`: Backend interface for cold storage
- `HotKv`, `HotKvRead`, `HotKvWrite`: Hot storage abstractions
- `HistoryRead`, `HistoryWrite`: Higher-level table operations

Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,6 @@ tokio-stream = "0.1"
tokio-util = { version = "0.7", features = ["rt"] }
itertools = "0.14"
lru = "0.16"
metrics = "0.24.2"
sqlx = { version = "0.8", default-features = false }
tracing = "0.1.44"
Loading