ci: harden Release workflow against tag races#102
Merged
Conversation
The dispatch-triggered release ran on main HEAD and silently required the newest tag to point at it — releasing seconds before the version tag finished propagating failed goreleaser's git-state check (seen on run 27357782836: 'git tag v1.30.1 was not made against commit 26b63e6'). Now build-linux resolves the release tag once (an explicit workflow_dispatch 'tag' input, or the newest tag on the default branch), checks it out, and exposes it as a job output; the windows, homebrew, and snap jobs check out that same tag. All jobs therefore build the identical tagged commit regardless of when the dispatch happens or what lands on main mid-run. A concurrency group queues a second dispatch instead of letting two releases interleave. Deliberately NOT triggering on tag push: tags are minted on every merge to main, and auto-publishing each merge to brew/snap/AUR/choco would change release cadence. Releases stay manual. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispatch-triggered release ran on main HEAD and silently required the newest tag to point at it — releasing seconds before the version tag finished propagating failed goreleaser's git-state check (seen on run 27357782836: 'git tag v1.30.1 was not made against commit 26b63e6').
Now build-linux resolves the release tag once (an explicit workflow_dispatch 'tag' input, or the newest tag on the default branch), checks it out, and exposes it as a job output; the windows, homebrew, and snap jobs check out that same tag. All jobs therefore build the identical tagged commit regardless of when the dispatch happens or what lands on main mid-run. A concurrency group queues a second dispatch instead of letting two releases interleave.
Deliberately NOT triggering on tag push: tags are minted on every merge to main, and auto-publishing each merge to brew/snap/AUR/choco would change release cadence. Releases stay manual.