Skip to content

ensures that NoArgsCtor is picked by jackson making all fields optional #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awildturtok wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

ensures that NoArgsCtor is picked by jackson making all fields optional #3863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec34ef
ensures that NoArgsCtor is picked by jackson making all fields optional
awildturtok Mar 24, 2026
ce75550
Update backend/src/main/java/com/bakdata/conquery/models/config/Datab…
awildturtok Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/src/main/java/com/bakdata/conquery/models/config/DatabaseConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.bakdata.conquery.models.config;

import jakarta.validation.constraints.NotNull;

import com.fasterxml.jackson.annotation.JsonCreator;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Data;
Expand All @@ -15,7 +18,7 @@
@Data
@Builder
@Jacksonized
@NoArgsConstructor
@NoArgsConstructor(onConstructor_ = {@JsonCreator})
Copy link
Copy Markdown
Collaborator

@thoniTUB thoniTUB Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ändert das irgendwas, oder enforced das nur dass der NoArgs genutzt wird?

Copy link
Copy Markdown
Collaborator Author

@awildturtok awildturtok Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das soll nur sicherstellen, dass über den NoArgs geöffnet wird.

@AllArgsConstructor
public class DatabaseConfig {

Expand All @@ -24,6 +27,7 @@ public class DatabaseConfig {
/**
* SQL vendor specific dialect used to transform queries to SQL
*/
@NotNull
private Dialect dialect;

/**
Expand Down
Loading