fix: prevent LEAD/LAG IGNORE NULLS panic without null bitmap (#23706) - #102
Open
epgif wants to merge 1 commit into
Open
fix: prevent LEAD/LAG IGNORE NULLS panic without null bitmap (#23706)#102epgif wants to merge 1 commit into
epgif wants to merge 1 commit into
Conversation
…23706) ## Which issue does this PR close? - Closes apache#23705. ## Rationale for this change Arrow arrays containing no null values commonly omit the null bitmap. The whole-partition evaluation path for `LEAD` and `LAG` with `IGNORE NULLS` unconditionally unwrapped that optional bitmap, causing a panic for valid non-null input arrays. ## What changes are included in this PR? - Fall back to the existing regular shift implementation when the input has no null bitmap. - Add a regression test covering both `LEAD` and `LAG` with an array that explicitly has no null bitmap. ## Are these changes tested? Yes. ## Are there any user-facing changes? `LEAD` and `LAG` with `IGNORE NULLS` no longer panic when the input Arrow array has no null bitmap. There are no public API changes. (cherry picked from commit a8d1af6)
Collaborator
Author
|
Coming up: influxdata/influxdb_iox#16691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow arrays containing no null values commonly omit the null bitmap.
The whole-partition evaluation path for
LEADandLAGwithIGNORE NULLSunconditionally unwrapped that optional bitmap, causing a panicfor valid non-null input arrays.
(cherry picked from commit a8d1af6)
for influxdata/EAR#7049