Skip to content

Update ExportGroup.php: remove facility access related fields#954

Merged
barryo merged 1 commit intoinex:mainfrom
lucix-mich:contacts-export-cleanup
Feb 16, 2026
Merged

Update ExportGroup.php: remove facility access related fields#954
barryo merged 1 commit intoinex:mainfrom
lucix-mich:contacts-export-cleanup

Conversation

@lucix-mich
Copy link
Copy Markdown
Contributor

Facility access seems to be a leftover from features now removed. Remove the two fields from the contacts export function.

I have:

  • [*] tested this doesn't break the export function, and that the result is what is expected
  • ensured unit tests all run without error
  • ran psalm and corrected any static analysis issues
  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

Facility access seems to be a leftover from features now removed. Remove the two fields from the contacts export function.
@barryo
Copy link
Copy Markdown
Member

barryo commented Feb 16, 2026

Thanks @lucix-mich - I'll add a migration to clean the database also in main.

@barryo barryo merged commit e8d64ea into inex:main Feb 16, 2026
barryo added a commit that referenced this pull request Feb 16, 2026
@lucix-mich
Copy link
Copy Markdown
Contributor Author

Thanks!
I hope whoever uses this will not depend on the exact fields in the generated output, or this might break things.
On the other hand, being able to select fields to export would be a worthwhile improvement to avoid breaking changes going further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants