Skip to content

Implement prepareForValidation method for NGINX#948

Closed
pashdown wants to merge 1 commit intoinex:mainfrom
pashdown:patch-1
Closed

Implement prepareForValidation method for NGINX#948
pashdown wants to merge 1 commit intoinex:mainfrom
pashdown:patch-1

Conversation

@pashdown
Copy link
Copy Markdown

@pashdown pashdown commented Dec 7, 2025

Under NGINX, the customer statistics would always return to "bits" and "day" regardless of menu selections. I don't know if this problem exists under Apache. Note that I was led to this fix by claude.ai.

PR template - remove this line and edit below

[BF] Summary of fix - fixes [inex|islandbridgenetworks]/IXP-Manager#x

[NF] New feature summary - closes [inex|islandbridgenetworks]/IXP-Manager#x

Longer description

In addition to the above, I have:

  • ensure unit tests all run without error
  • ran pslam and corrected any static analysis issues
  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

Under NGINX, the customer statistics would always return to "bits" and "day" regardless of menu selections.  I don't know if this problem exists under Apache.  Note that I was led to this fix by claude.ai.
@barryo barryo added the Pending CLA Contributor license agreement not signed label Feb 16, 2026
@barryo
Copy link
Copy Markdown
Member

barryo commented Feb 16, 2026

Hey @pashdown - can you sign the CLA so we can merge this (after testing) please - https://docs.ixpmanager.org/latest/dev/cla/ ?

@barryo
Copy link
Copy Markdown
Member

barryo commented Feb 18, 2026

I'm going to close this for now, as it may already be solved via e63143f which will be part of v7.1.

@barryo barryo closed this Feb 18, 2026
@pashdown
Copy link
Copy Markdown
Author

pashdown commented Mar 2, 2026

Just saw this. I've signed the CLA. I'll test out 7.1 and if there is a problem, redo it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending CLA Contributor license agreement not signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants