Flop counting

[inducer]

Very WIP right now.

cc @majosm

[majosm]

ConditionalDependencyMapper addition is unused (I used it in an earlier draft but ended up not needing it). I left it in because it doesn't harm anything and seems potentially useful.

@inducer I think this is ready for a first look, apart from some basedpyright errors that I don't understand. Probably best to go commit by commit.

[majosm]

@inducer I ran into a complication with the flop counting for conditionals. When mirgecom projects something from interior/boundary faces to all faces, meshmode's direct connection code creates an AdvancedIndexInContiguousAxes (code) shaped like the all-faces discretization, and then it follows up with an IndexLambda that zeros out the entries corresponding to elements that aren't part of the input discretization. You can see this for wave below:

Since the flop counting currently evaluates flops for Conditional as max(nflops_then, nflops_else), this is causing the number of flops to be overestimated for this part of the DAG. It's counting the flops (in the case of wave) over 1536 faces instead of the 64 that end up being nonzero. I'm not sure how to deal with this, since it's data-dependent. I could maybe hack in a check for condition being something easily evaluated and then just count the number of true/false cases, but beyond that I don't know how to resolve this. Any thoughts?

[majosm]

@inducer Do you know what's causing these basedpyright errors for rec? Is this another instance of the thing that should be added to the baseline?

Also, about the Conditional flop count handling: if we're going to model it after GPU execution, should it be counted as max(nflops_then, nflops_else) or sum(nflops_then, nflops_else)?

[majosm]

@inducer This is ready for a look again when you have a chance.

[inducer]

Just the enum thing and then this is good to go from my perspective. 🎉

[inducer]

Let's do a separate node type for nflops.

[majosm]

Added.

[kaushikcfd]

LGTM! Thanks, I will be a user of this FLOP-counting routine soon! :)

[majosm]

Ready again @inducer.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.