Draft
Conversation
2 tasks
…ed in it. Not the axis as well.
…n the variable even if it is not initially subscripted.
…ted programming constructs.
Contributor
Author
|
@inducer This is ready for the first round of review. |
inducer
reviewed
Aug 1, 2024
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Some thoughts from a first scroll.
inducer
reviewed
Aug 5, 2024
pytato/transform/parameter_study.py
Outdated
|
|
||
| # {{{ Operations with multiple predecessors. | ||
|
|
||
| def _mult_pred_same_shape(self, expr: Stack | Concatenate) -> tuple[ArraysT, |
Owner
There was a problem hiding this comment.
Please think of a better name for this.
Contributor
Author
There was a problem hiding this comment.
Updated to _broadcast_predecessors_to_same_shape
…the original array.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
inducer
reviewed
Aug 26, 2024
| same study then you need to have the same type of | ||
| :class:`ParameterStudyAxisTag`. | ||
| """ | ||
| size: int |
Owner
There was a problem hiding this comment.
This information is already contained in the length of the tagged axis (via the array's shape), so I feel like having this would be redundant.
pytato/transform/parameter_study.py
Outdated
|
|
||
| StudiesT = tuple[ParameterStudyAxisTag, ...] | ||
| ArraysT = tuple[Array, ...] | ||
| KnownShapeType = tuple[IntegralT, ...] |
Owner
There was a problem hiding this comment.
Should use same type as Array.shape. I see no issue with parametric axis lengths for non-study axes.
pytato/transform/parameter_study.py
Outdated
| and so the shape of :math:`\mathbf{Z}` will be | ||
| (:math:`\mathbf{orig\_shape}`, :math:`\mathbf{S1}.size`, :math:`\mathbf{S2}.size`). | ||
|
|
||
| A parameter study is specified in an array by tagging the corresponding axis |
Owner
There was a problem hiding this comment.
You get this far in before saying what a parameter study is? 🤔
|
|
||
| study_to_arrays: dict[frozenset[ParameterStudyAxisTag], ArraysT] = {} | ||
|
|
||
| active_studies: set[ParameterStudyAxisTag] = set() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a mapper to expand a single instance DAG into a multiple independent instance DAG.