Allow passing user and branch to downstream#22
Conversation
You're welcome! duck :)
Sadly, no. I've wished for that myself, too. |
ci-support.sh
Outdated
| url="https://github.com/$user_name/$proj_name.git" | ||
| if [[ "$proj_name" = "mirgecom" ]]; then | ||
| git clone "https://github.com/illinois-ceesd/$proj_name.git" | ||
| default_url="https://github.com/illinois-ceesd/$proj_name.git" | ||
| else | ||
| git clone "https://github.com/inducer/$proj_name.git" | ||
| default_url="https://github.com/inducer/$proj_name.git" | ||
| fi |
There was a problem hiding this comment.
Hmm. I know what was here before wasn't beautiful, but this logic seems like one step too far. I also know that I'm more likely to say this because it's not me committing the crime.
Realistically, I think the better answer is to permit passing in a pip-style git URL: git+https://...@branchname. That ought to be easy enough to pick apart?
There was a problem hiding this comment.
Not easy at all! Bash string slicing and dicing is horrible 😨
alexfikl
force-pushed
the
extend-downstream
branch
from
360fda1 to
d514ccc
Compare
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
LGTM! (And 🎉 much nicer! Thanks!) Let's see how it does in inducer/pymbolic#74, and if that comes back clean, then it's good to go in.
Yep! Seems to be working, the failures this far are from the EDIT: The |
|
Thx! |
2 participants
Hacked this in here to be able to use (see inducer/pymbolic#74)
and have it pick up another repo/branch. Any way to test that this doesn't break the world? (Tried it locally and it was nice enough to rewrite my
gitconfig, but it did clone things correctly)Suggestions for handling this more gracefully very welcome!