Fix commit.txt always checked#614
Open
adamdickmeiss wants to merge 4 commits into
Open
Conversation
Even if the commit.txt is unchanged, it must still be touched so this rule is not always executed.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the broker Makefile rule that generates commit.txt so it is always updated, preventing the commit ID target from being considered perpetually out-of-date when the content hasn’t changed.
Changes:
- Simplified
$(COMMIT_ID)generation to always write the current short Git SHA. - Removed conditional “write only if changed” logic for
commit.txt.
Contributor
|
@adamdickmeiss what was wrong with the previous approach? |
Contributor
Author
If commit.txt is not changed due a condition, the modification date is, thus, not modified, make will always repeat the rule. It seems wrong that a target is not updated to make |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if the commit.txt is unchanged, it must still be touched so this rule is not always executed.