Add readiness probes for web-app and website dev servers#145
Open
Add readiness probes for web-app and website dev servers#145
Conversation
Contributor
|
Contributor
Coverage
|
dkzlv
approved these changes
Apr 3, 2026
Without probes, dev-check considers these services ready as soon as pnpm install starts. Now it waits for Vite (port 3265) and Astro (port 4321) to actually be serving before proceeding. Astro needs --host to bind to 0.0.0.0 so the 127.0.0.1 readiness probe can connect. Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
9690a37 to
0e8d37e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web-app(Vite, port 3265) andwebsite(Astro, port 4321) inprocess-compose.yml.Motivation
Follow-up to #136. Without readiness probes,
dev-checkconsiders these services ready as soon aspnpm installstarts running. Now all five services have readiness probes, sodev-checkwaits for every dev server to actually be serving before proceeding.Testing
Covered by the
dev-checkCI job.Tag
@indentto continue the conversation here.