Skip to content

Add readiness probes for web-app and website dev servers#145

Open
pcarrier wants to merge 1 commit intomainfrom
indent-2026-04-03-webapp-website-readiness-probes
Open

Add readiness probes for web-app and website dev servers#145
pcarrier wants to merge 1 commit intomainfrom
indent-2026-04-03-webapp-website-readiness-probes

Conversation

@pcarrier
Copy link
Copy Markdown
Contributor

@pcarrier pcarrier commented Apr 3, 2026

Summary

  • Adds HTTP readiness probes for web-app (Vite, port 3265) and website (Astro, port 4321) in process-compose.yml.

Motivation
Follow-up to #136. Without readiness probes, dev-check considers these services ready as soon as pnpm install starts running. Now all five services have readiness probes, so dev-check waits for every dev server to actually be serving before proceeding.

Testing
Covered by the dev-check CI job.

Open in Indent
Tag @indent to continue the conversation here.

@indent
Copy link
Copy Markdown
Contributor

indent bot commented Apr 3, 2026

PR Summary

This PR adds HTTP readiness probes for the web-app and website dev servers in process-compose.yml, so that dependent services wait for the servers to actually be serving (Vite on port 3265, Astro on port 4321) before proceeding, rather than considering them ready as soon as pnpm install starts.

  • Added readiness_probe with http_get to web-app (port 3265) and website (port 4321), matching the existing gateway probe pattern
  • Both probes use the same timing parameters as other services: 5s initial delay, 2s poll interval, 300 failure threshold (~10 min timeout)

Issues

No issues found.

CI Checks

All CI checks pass on the latest commit (0e8d37e). The --host flag added to the Astro dev command resolved the previous dev-check timeout.

@pcarrier pcarrier added the indent label Apr 3, 2026 — with indent
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Coverage

Crate Lines Functions Regions
alacritty-driver 59.7% (529/886) 62.5% (40/64) 59.8% (754/1261)
browser 0.0% (0/807) 0.0% (0/65) 0.0% (0/1370)
cli 43.8% (1426/3256) 59.6% (190/319) 49.4% (2514/5088)
fonts 76.9% (486/632) 85.5% (47/55) 78.2% (922/1179)
gateway 35.2% (242/688) 32.4% (23/71) 26.9% (293/1088)
remote 83.0% (1900/2290) 91.1% (184/202) 85.8% (3612/4212)
server 43.7% (1548/3544) 58.3% (176/302) 44.1% (2606/5906)
webrtc-forwarder 0.0% (0/1464) 0.0% (0/93) 0.0% (0/2501)
webserver 59.3% (233/393) 75.9% (44/58) 64.8% (455/702)
Total 45.6% (6364/13960) 57.3% (704/1229) 47.9% (11156/23307)

Without probes, dev-check considers these services ready as soon as pnpm
install starts. Now it waits for Vite (port 3265) and Astro (port 4321)
to actually be serving before proceeding. Astro needs --host to bind to
0.0.0.0 so the 127.0.0.1 readiness probe can connect.

Generated with [Indent](https://indent.com)
Co-Authored-By: Indent <noreply@indent.com>
@indent indent bot force-pushed the indent-2026-04-03-webapp-website-readiness-probes branch from 9690a37 to 0e8d37e Compare April 3, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants