validate_configs.py rewritten in GoLang#3
Open
andylockran wants to merge 6 commits intoimposter-project:mainfrom
Open
validate_configs.py rewritten in GoLang#3andylockran wants to merge 6 commits intoimposter-project:mainfrom
andylockran wants to merge 6 commits intoimposter-project:mainfrom
Conversation
andylockran
commented
Jan 8, 2025
Contributor
|
I suspect we might want this to be its own go module, then it can be self-contained, and not be coupled to this implementation. we should, for example, probably move the config schema(s) out to their own repo. maybe this tool lives with them to do validation, and then regardless of the engine implementation (Go, JVM), it's a standalone repo that just owns the config schema and validates files to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've not written much golang, so have tried to recreate the existing python script for validating configs using golang.
Things to discuss:
Anyway, first pass and don't expect this to get merged as-is.