Skip to content

fix: removes the -t argument from imposter down. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
outofcoffee merged 2 commits into from
May 28, 2026
Merged

fix: removes the -t argument from imposter down. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d686a
fix: removes the -t argument from imposter down.
zzcgumn May 28, 2026
e499a8c
fix: stop all mocks in stop-mocks and deprecate engine-type
outofcoffee May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ Starts the Imposter mock server in the background, and waits for it to be ready.
- `base-url`: Base URL of the mock server (e.g. `http://localhost:8080`)

### 3. Stop Mocks (`stop-mocks`)
Stops the running Imposter mock server.
Stops all running Imposter mock servers, regardless of engine type.

```yaml
- uses: imposter-project/imposter-github-action/stop-mocks@v1
with:
# Optional: Type of mock engine to use (jvm or docker)
engine-type: 'docker' # default: 'docker'
```

> [!NOTE]
> The `engine-type` input is deprecated and ignored; all managed mocks are stopped regardless of engine type.

## Sample Workflow

Here's a complete example showing how to use all three actions in a workflow:
Expand Down Expand Up @@ -101,8 +101,6 @@ jobs:
# Stop mock server
- name: Stop Mocks
uses: imposter-project/imposter-github-action/stop-mocks@v1
with:
engine-type: 'docker' # Should match the engine-type used in start-mocks
```

## Configuration
Expand Down
13 changes: 9 additions & 4 deletions stop-mocks/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
name: 'Stop Imposter Mocks'
description: 'Stops the running Imposter mock server'
description: 'Stops all running Imposter mock servers'

inputs:
engine-type:
description: 'Type of mock engine to use (jvm or docker)'
description: 'Deprecated and ignored. All managed mocks are stopped regardless of engine type.'
required: false
default: 'docker'
deprecationMessage: "The 'engine-type' input is deprecated and no longer used; all managed mocks are stopped regardless of engine type."

runs:
using: "composite"
steps:
- name: Warn on deprecated engine-type input
if: ${{ inputs.engine-type != '' }}
shell: bash
run: echo "::warning title=Deprecated input::The 'engine-type' input of stop-mocks is deprecated and no longer used; all managed mocks are stopped regardless of engine type."

- name: Stop Imposter server
shell: bash
run: imposter down -t ${{ inputs.engine-type }}
run: imposter down --all
Loading