feat: Add custom settings for pod- and containerSecurityContext instead of global securityContext#198
Closed
kaufmo wants to merge 1 commit intoimgproxy:masterfrom
Closed
feat: Add custom settings for pod- and containerSecurityContext instead of global securityContext#198kaufmo wants to merge 1 commit intoimgproxy:masterfrom
kaufmo wants to merge 1 commit intoimgproxy:masterfrom
Conversation
…yContext instead of global securityContext
|
definitely needed 👍 |
Contributor
Author
|
@DarthSim @dragonsmith can somebody pls take a look here? |
Member
|
Hey @kaufmo! |
Collaborator
|
As Darthsim mentioned above, though, this approach would break backward compatibility. There’s also #201, which addresses the issue in the same way but without renaming. I appreciate your contribution! At this point, I think the other PR should take precedence. Thank you again for your efforts here. |
Collaborator
|
However, naming here is much more logical |
Collaborator
|
Thank you again for implementing this. I've merged #198, and fixed the naming as you proposed here, with deprecation warning for an old value. Closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this one was merged in a custom branch and never got it into master so new try (#157)