Skip to content

Fix bioformats.get_stage_coords and add option to resultstable.add_results #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehrenfeu merged 3 commits into from
Jan 14, 2026
Merged

Fix bioformats.get_stage_coords and add option to resultstable.add_results #97

ehrenfeu merged 3 commits into from
Jan 14, 2026

Conversation

@rohangirishrao
Copy link
Contributor

@rohangirishrao rohangirishrao commented Apr 24, 2025 •
edited by ehrenfeu
Loading

Fixes issues #93 and #98

@rohangirishrao rohangirishrao mentioned this pull request Apr 24, 2025
Closed
@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 25%. Comparing base (26f64c9) to head (9cf3819).
⚠️ Report is 25 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/resultstable.py 0% 10 Missing ⚠️
src/imcflibs/imagej/bioformats.py 0% 1 Missing ⚠️
Additional details and impacted files 
@@         Coverage Diff          @@
##           devel    #97   +/-   ##
====================================
- Coverage     25%    25%   -0%     
====================================
  Files         25     25           
  Lines       1688   1718   +30     
====================================
  Hits         421    421           
- Misses      1267   1297   +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rohangirishrao
Copy link
Contributor Author

rohangirishrao commented May 8, 2025

Also fixes #98

@rohangirishrao rohangirishrao mentioned this pull request May 8, 2025
Closed
@rohangirishrao rohangirishrao changed the title Fix issue #93, return only filename and not entire path Fix issue #93 and #98 May 8, 2025
@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 14, 2026
@ehrenfeu ehrenfeu added the new-minor Change introduced in PR will require a new minor release. label Jan 14, 2026
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 14, 2026
@ehrenfeu ehrenfeu changed the title Fix issue #93 and #98 Fix bioformats.get_stage_coords and add option to resultstable.add_results Jan 14, 2026
This was linked to issues Jan 14, 2026
Fix bioformats.get_stage_coords to only return the name of the series and not the full path #93
Closed
Add option to set results in selected_indexes for resultstable.add_results #98
Closed
@ehrenfeu ehrenfeu self-requested a review January 14, 2026 13:11
@ehrenfeu ehrenfeu added bug Something isn't working enhancement New feature or request labels Jan 14, 2026
@ehrenfeu ehrenfeu added the changelog Needs to be mentioned in release changelogs label Jan 14, 2026
@ehrenfeu ehrenfeu merged commit e50ee1e into imcf:devel Jan 14, 2026
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in imcflibs Jan 14, 2026
@ehrenfeu ehrenfeu mentioned this pull request Jan 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehrenfeu ehrenfeu ehrenfeu approved these changes

Assignees

@ehrenfeu ehrenfeu

@rohangirishrao rohangirishrao

Labels

bug Something isn't working changelog Needs to be mentioned in release changelogs enhancement New feature or request new-minor Change introduced in PR will require a new minor release.

Projects

imcflibs
Status: Done

Milestone

2.0.0

2 participants

@rohangirishrao @ehrenfeu