Skip to content

Conversation

@lguerard
Copy link
Contributor

@lguerard lguerard commented Dec 8, 2025

  • Added a check to ensure both images have the same number of slices.
  • Exits with an error message if the slice counts differ.
  • Adjusted the subtraction operation to handle stack images appropriately.

* Added a check to ensure both images have the same number of slices.
* Exits with an error message if the slice counts differ.
* Adjusted the subtraction operation to handle stack images appropriately.
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 25%. Comparing base (745fc61) to head (0a46264).
⚠️ Report is 27 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/misc.py 0% 5 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           devel   #117   +/-   ##
====================================
- Coverage     25%    25%   -0%     
====================================
  Files         25     25           
  Lines       1688   1694    +6     
====================================
  Hits         421    421           
- Misses      1267   1273    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Ensure the calibration of the first image is applied to the result of the subtraction.
@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 14, 2026
@ehrenfeu ehrenfeu added bug Something isn't working next-release Issues blocking the next release labels Jan 14, 2026
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 14, 2026
@ehrenfeu ehrenfeu self-assigned this Jan 14, 2026
Copy link
Member

@ehrenfeu ehrenfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using sys.exit in a library is pretty much a disaster, as this will kill any application using it.
Instead, raise an exception that allows the calling code to handle it if necessary / desirable.

@ehrenfeu ehrenfeu moved this from In review to In progress in imcflibs Jan 14, 2026
@ehrenfeu
Copy link
Member

Removed this from 2.0.0 in order to prevent it from blocking the release. Feel free to re-add once this is fixed or in case it's strictly necessary for the milestone.

@ehrenfeu ehrenfeu added the changelog Needs to be mentioned in release changelogs label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working changelog Needs to be mentioned in release changelogs next-release Issues blocking the next release

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants