-
Notifications
You must be signed in to change notification settings - Fork 3
Fix function to not split time points by default #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=====================================
Coverage 25% 25%
=====================================
Files 25 25
Lines 1688 1691 +3
=====================================
+ Hits 421 423 +2
- Misses 1267 1268 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have this behavior explained in the function's docstring.
ehrenfeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, by its nature the parameter timepoints_per_partition should rather be boolean than int as it's only having two values with the semantics "split" or "don't split"...
Let's do this now as we're anyway aiming for a major release.
|
Got it wrong, it is indeed an ➡️ Explain this in the docstring instead, but leave the code as it is. |
ehrenfeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 The default behavior changed, so this has to be mentioned in the changelog (#126).
|
Pytest 🕵🏼 is failing, do we need to update the testing scripts to pull in the latest BDV / Fiji? I guess this will also be the case for other PR's... |
Needed because the current function is ignoring the user parameter and always splits by time point.