Skip to content

Add method to read metadata back from the xml #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lguerard wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

Add method to read metadata back from the xml #102

lguerard wants to merge 5 commits into from
+86 −5

Conversation

@lguerard
Copy link
Contributor

@lguerard lguerard commented May 6, 2025

Fixes #96

@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 24%. Comparing base (745fc61) to head (42123c6).
⚠️ Report is 25 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/bdv.py 13% 27 Missing ⚠️
Additional details and impacted files 
@@         Coverage Diff          @@
##           devel   #102   +/-   ##
====================================
- Coverage     25%    24%   -1%     
====================================
  Files         25     25           
  Lines       1688   1750   +62     
====================================
+ Hits         421    426    +5     
- Misses      1267   1324   +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 14, 2026
@ehrenfeu ehrenfeu linked an issue Jan 14, 2026 that may be closed by this pull request
Add bdv method to return info about project #96
Closed
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 14, 2026
@ehrenfeu ehrenfeu self-requested a review January 14, 2026 12:51
@ehrenfeu ehrenfeu added enhancement New feature or request changelog Needs to be mentioned in release changelogs labels Jan 14, 2026
@ehrenfeu ehrenfeu self-assigned this Jan 14, 2026
ehrenfeu
ehrenfeu requested changes Jan 14, 2026
View reviewed changes
src/imcflibs/imagej/bdv.py
if last_nodes.getLength() > 0:
nbr_tp = int(last_nodes.item(0).getTextContent()) + 1
except Exception as e:
log.error("Error extracting metadata from XML: {0}".format(str(e)))
Copy link
Member

@ehrenfeu ehrenfeu Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid Python 2.7 syntax...? 😳

@ehrenfeu ehrenfeu moved this from In review to In progress in imcflibs Jan 14, 2026
@ehrenfeu
Copy link
Member

ehrenfeu commented Jan 14, 2026

#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehrenfeu ehrenfeu ehrenfeu requested changes

Assignees

@ehrenfeu ehrenfeu

Labels

changelog Needs to be mentioned in release changelogs enhancement New feature or request

Projects

imcflibs
Status: In progress

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Add bdv method to return info about project

2 participants

@lguerard @ehrenfeu