-
Notifications
You must be signed in to change notification settings - Fork 3
Add function to convert size from bytes to a more readable format #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cdbe7e4
Add function to convert size from bytes to a more readable format
lguerard 64a431f
Fix Ruff linting
lguerard 7635330
feat(misc): Rename bytes to human-readable conversion function
lguerard 6e7b2fe
test: Add docstrings to byte conversion tests
lguerard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| """Tests for `imcflibs.imagej.misc` utility functions.""" | ||
|
|
||
| from imcflibs.imagej.misc import bytes_to_human_readable | ||
|
|
||
|
|
||
| def test_bytes_to_human_readable_simple(): | ||
| """Ensure common sizes are formatted into human-readable strings.""" | ||
| assert bytes_to_human_readable(500) == "500.0 bytes" | ||
| assert bytes_to_human_readable(2048) == "2.0 KB" | ||
| assert bytes_to_human_readable(1024 * 1024) == "1.0 MB" | ||
| assert bytes_to_human_readable(5 * 1024**3) == "5.0 GB" | ||
|
|
||
|
|
||
| def test_bytes_to_human_readable_large(): | ||
| """Verify formatting for large sizes such as terabytes.""" | ||
| # 1.5 TB in bytes should format as 1.5 TB | ||
| size = int(1.5 * (1024**4)) | ||
| assert bytes_to_human_readable(size) == "1.5 TB" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be more careful when crafting / assembling commits, those changes (originating from code linting and formatting tools) are completely unrelated to the PR and destroy the logical context of the code history when being committed with the message of the actual change.