Add notification service example to Factory Method README#3515
Open
shabinfrancis wants to merge 1 commit into
Open
Add notification service example to Factory Method README#3515shabinfrancis wants to merge 1 commit into
shabinfrancis wants to merge 1 commit into
Conversation
PR SummaryAdds a real-world example to the Factory Method pattern documentation, showing how a notification system can create Email, SMS, or Push notification services via the Factory Method while keeping the client independent of concrete implementations. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- acaf94c: Add notification service example to Factory Method README
Files Processed (1)
- factory-method/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
factory-method/README.md [34-36]
readability: "Improve README blockquote formatting and wording"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3515 +/- ##
============================================
- Coverage 83.30% 83.23% -0.08%
+ Complexity 4025 4020 -5
============================================
Files 1060 1060
Lines 14246 14246
Branches 686 686
============================================
- Hits 11867 11857 -10
- Misses 2094 2100 +6
- Partials 285 289 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
What does this PR do?