Skip to content

Adding Currency Convertor example#3307

Open
DEVANSH-GAJJAR wants to merge 2 commits intoiluwatar:masterfrom
DEVANSH-GAJJAR:feature/currency-convertor
Open

Adding Currency Convertor example#3307
DEVANSH-GAJJAR wants to merge 2 commits intoiluwatar:masterfrom
DEVANSH-GAJJAR:feature/currency-convertor

Conversation

@DEVANSH-GAJJAR
Copy link
Copy Markdown

Pull Request Template

What does this PR do?

This PR adds a new example implementation of the Currency Converter design pattern in Java.
The example demonstrates a basic currency conversion utility that converts between multiple currencies using fixed exchange rates.

It showcases the application of the Strategy pattern by allowing different conversion strategies to be swapped easily.
This helps learners understand how to decouple conversion logic and improve flexibility in financial applications.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 28, 2025

PR Summary

Introduces a Java-based Currency Converter example that fetches live exchange rates from an external API and applies them to a user-specified quantity. This example demonstrates a console-based workflow and includes a Maven project setup with dependencies for HTTP requests and JSON parsing, plus a minimal entry point class.

Changes

File Summary
currency-convertor/currency-convertor/.gitignore Introduced repository-specific ignore rules for Maven targets, IDE metadata, and common build artifacts to keep the currency-converter project clean.
currency-convertor/currency-convertor/pom.xml Added Maven configuration for the Currency Converter module, declaring org.example:CurrencyConverter2:1.0-SNAPSHOT with dependencies on OkHttp and org.json and Java 11 compiler settings.
currency-convertor/currency-convertor/src/main/java/com/currencyconvertor.java Implemented a console-based currency converter: prompts user for from/to currencies and quantity, fetches latest rates from the Frankfurter API via OkHttp, parses JSON with org.json, and prints the converted value.
currency-convertor/currency-convertor/src/main/java/org/example/Main.java Provided a simple example main in org.example package that prints a greeting and iterates, serving as a placeholder/demo entry point.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • a38bb65: Adding Currency Convertor example
Files Processed (4)
  • currency-convertor/currency-convertor/.gitignore (1 hunk)
  • currency-convertor/currency-convertor/pom.xml (1 hunk)
  • currency-convertor/currency-convertor/src/main/java/com/currencyconvertor.java (1 hunk)
  • currency-convertor/currency-convertor/src/main/java/org/example/Main.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)

@sonarqubecloud
Copy link
Copy Markdown

@DEVANSH-GAJJAR
Copy link
Copy Markdown
Author

Hi there ,
I’ve added a new example Currency Converter implementation demonstrating the Strategy design pattern.
All checks have passed ✅ and the branch has no conflicts.
Requesting your review whenever you get a chance. Thanks!

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Nov 21, 2025
@DEVANSH-GAJJAR
Copy link
Copy Markdown
Author

Hi maintainers,
Kindly review this PR when you get a chance.
If everything looks good, please proceed with the merge.
Thank you for your time and consideration!

@github-actions github-actions bot removed the Stale label Nov 24, 2025
@DEVANSH-GAJJAR
Copy link
Copy Markdown
Author

Hi there ,

just a gentle ping in case this PR is still relevant.

Happy to make any changes if needed. Thanks!

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Mar 28, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 820e3f1: Merge branch 'master' into feature/currency-convertor
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

@github-actions github-actions bot removed the Stale label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant