Switch out nullish operator for ternary to allow loading in fastboot#49
Closed
jkeen wants to merge 1 commit intoijlee2:mainfrom
jkeen:main
Closed
Switch out nullish operator for ternary to allow loading in fastboot#49jkeen wants to merge 1 commit intoijlee2:mainfrom jkeen:main
jkeen wants to merge 1 commit intoijlee2:mainfrom
jkeen:main
Conversation
Owner
|
Thanks for the feedback! Yeah, the nullish coalescing operator bit me too in a production app that has FastBoot. I discussed this issue with a few people on Discord, and I think the solution is for the end user of this addon to update their Can you try the solution at ember-fastboot/ember-cli-fastboot#770 and let me know if that helps? Another reference is ember-fastboot/ember-cli-fastboot#764. I think what I can do is to update the documentation to add a warning for FastBoot users. Would this be okay with you? |
Author
|
Ah ha! You're right. I tried googling for this and didn't find it, so yeah -- I think adding something to the readme would be very helpful. |
Owner
|
Sounds good. I will work on updating the README tonight! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love the nullish operator, but unfortunately fastboot errors upon startup with it in there. This PR switches it for the ternary operator.
P.S. Nice addon!