refactor: Rename algo to algorithm in page_rank(), feedback_arc_set() and feedback_vertex_set() - #2859
Open
krlmlr wants to merge 1 commit into
Open
refactor: Rename algo to algorithm in page_rank(), feedback_arc_set() and feedback_vertex_set()#2859krlmlr wants to merge 1 commit into
algo to algorithm in page_rank(), feedback_arc_set() and feedback_vertex_set()#2859krlmlr wants to merge 1 commit into
Conversation
…c_set()` and `feedback_vertex_set()` (#2788, #526) The legacy `algo` spelling is recovered by the generated ARG_HANDLE blocks and soft-deprecated; abbreviations of both spellings are guarded as ambiguous. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTPj4qNv2FWui6etixZeuR
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 12230f8 is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2788 (PR 1 of a stack of 6, least controversial first); implements the
algo→algorithmleg of #526.What this does
Renames the
algoargument toalgorithminpage_rank(),feedback_arc_set()andfeedback_vertex_set()— the three functions the Comprehensive plan: argument renames for 3.0.0 #2788 survey lists under thealgospelling. All three already carry their 3.0.0 keyword-only migration entries withalgoafter..., so the rename is a pure registry change (algo = algorithmbare-symbol rename intools/migrations/), and legacyalgo =callers are recovered with the same single soft-deprecation as positional callers:Abbreviations that could mean either spelling (
a,al,alg) are rejected as ambiguous by the regenerated ARG_HANDLE guards.The deprecated
page.rank()wrapper keeps its frozenalgoformal (now documented locally with a deprecated badge, since@inheritParams page_rankno longer carries it) and forwards toalgorithm.Tests: named uses updated, plus new coverage that the legacy name is recovered (snapshot for
page_rank(algo = ),expect_deprecatedfor the two feedback functions).Out of scope
method(12 algorithm-choice + 2 comparison-metric functions),implementation(2) andimpl(1) are the open "algorithm family" questions in #2788 and are not touched here.🤖 Generated with Claude Code
https://claude.ai/code/session_01RTPj4qNv2FWui6etixZeuR
Generated by Claude Code