Skip to content

refactor(ia): fix type errors detected with ty #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cesarcoatl merged 1 commit into from
Jan 20, 2026
Merged

refactor(ia): fix type errors detected with ty #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/com/inductiveautomation/ignition/common/opc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ def getItemType(self):

def getProperties(self):
# type: () -> List[BrowseElement.PropertyElement]
return self._properties.values()
pass
Copy link

@sourcery-ai sourcery-ai bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Replacing getProperties return with pass will break callers expecting a list of PropertyElement

This changes the method from returning a list-like collection of BrowseElement.PropertyElement to returning None, which will break existing callers (iteration, len, indexing, etc.). If the method is meant to be unimplemented, raise NotImplementedError; otherwise it should continue returning the underlying collection (or an appropriate wrapper).


def getProperty(self, id_):
# type: (int) -> BrowseElement.PropertyElement
return self._properties[id_]
pass

def getServer(self):
# type: () -> Union[str, unicode]
Expand Down
2 changes: 1 addition & 1 deletion src/com/inductiveautomation/ignition/common/script/abc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def update(self, *args, **kwargs):
# type: (*PyObject, **Union[str, unicode]) -> None
raise NotImplementedError

def __setitem__(self, pyKey, value):
def __setitem__(self, pyKey, pyValue):
# type: (PyObject, PyObject) -> None
raise NotImplementedError

Expand Down
2 changes: 1 addition & 1 deletion stubs/stubs/com/inductiveautomation/ignition/common/script/abc/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class AbstractMutableJythonMap(MutableJythonMap):
self, pyKey: PyObject, def_: Optional[PyObject] = ...
) -> PyObject: ...
def update(self, *args: PyObject, **kwargs: Union[str, unicode]) -> None: ...
def __setitem__(self, pyKey: PyObject, value: PyObject) -> None: ...
def __setitem__(self, pyKey: PyObject, pyValue: PyObject) -> None: ...
def __delitem__(self, pyKey: PyObject) -> None: ...

class AbstractMutableJythonSequence(AbstractJythonSequence, MutableJythonSequence):
Expand Down