Skip to content

Document panic=abort limitation#4

Open
e00E wants to merge 1 commit intoiex-rs:masterfrom
e00E:doc-panic
Open

Document panic=abort limitation#4
e00E wants to merge 1 commit intoiex-rs:masterfrom
e00E:doc-panic

Conversation

@e00E
Copy link
Copy Markdown

@e00E e00E commented Sep 8, 2024

No description provided.

@purplesyringa
Copy link
Copy Markdown
Member

purplesyringa commented Sep 8, 2024

I'm hesitant whether to accept this PR. I have plans to amend iex to support panic=abort environments by switching back to Result, so this passage won't stay for long. I also don't think publishing a patch version just for a doc update is a good idea, so I'm not sure if it'll ever see the light.

I think I'll leave this issue open as a reminder to me, but won't merge it yet. Feel free to barge in if you feel leaving it in the current state is misleading and dangerous, though.

@e00E
Copy link
Copy Markdown
Author

e00E commented Sep 8, 2024

That's fine. I like turning iex::Result into std::Result when unwinding is not supported . How do you detect the ability to unwind at compile time on stable?

@e00E
Copy link
Copy Markdown
Author

e00E commented Sep 8, 2024

Alternatively, you could merge now without creating a release. If you address the issue before the next release, remove the comment.

@purplesyringa
Copy link
Copy Markdown
Member

How do you detect the ability to unwind at compile time on stable?

rust-lang/rust#93658

Alternatively, you could merge now without creating a release. If you address the issue before the next release, remove the comment.

I think I'm less likely to forget about it with an open issue/PR. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants