Fix rounding error when getting VisualLine#425
Open
trijnsburger wants to merge 1 commit intoicsharpcode:masterfrom
Open
Fix rounding error when getting VisualLine#425trijnsburger wants to merge 1 commit intoicsharpcode:masterfrom
trijnsburger wants to merge 1 commit intoicsharpcode:masterfrom
Conversation
Member
|
Can you please provide reproduction steps (using ICSharpCode.AvalonEdit.Sample.exe) for this problem? The I would expect the "lower than" relation to be not affected by epsilon errors. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rounding error occasionally occurs here (found when using RectangleSelect), causing this method to unexpectedly return null, which in turn causes RectangleSelection.ReplaceSelectionWithText() to incorrectly set textArea.Caret.Position to (Line = 1, Column = 1).
Note that the epsilon value of 1e-12 is an estimation based on the accuracy of the visualTop value, which has 13 decimals when its integer value is in the thousands (4 digits).