[patch] fix some stack trace dumping errors#2295
Open
stonepd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While running mas install for issue https://jsw.ibm.com/browse/MASCORE-13906
I got a couple of annoying stack trace dumping errors,
1 - when running
mas installin non interactive mode and I have not logged on to the kubernetes cluster2 - when entering a blank "Custom channel for manage"
This fixes those by
1 - checking for a valid client in lookupTargetArchitecture, also change subsequent warning from
The Kubernetes dynamic Client is not availableto a more friendlyNot successfully connected to a Kubernetes cluster2 - validating that any entered value for application Custom channels are not empty
Testing
Tested by running the built CLI