Skip to content

[patch] Remove prompts requesting RSL URL, RSL Org ID, and RSL token from aiservice-install#2244

Merged
whitfiea merged 42 commits into
masterfrom
masaib-2151
May 21, 2026
Merged

[patch] Remove prompts requesting RSL URL, RSL Org ID, and RSL token from aiservice-install#2244
whitfiea merged 42 commits into
masterfrom
masaib-2151

Conversation

@PalVala
Copy link
Copy Markdown
Contributor

@PalVala PalVala commented May 5, 2026 •
edited
Loading

Changes

  • remove prompts for RSL URL, RSL Org ID, and RSL token from aiservice-install
  • align CLI flow so these values are obtained from the AI config app response instead of manual interactive input
  • update supporting validation, Tekton params/templates, and installation docs to reflect the new behavior

Reason

  • The prompts were redundant during interactive aiservice-install because the required values already come from the AI config app response body.

Relevant PR

Testing

  • validated mas install
  • validated mas aiservice-install
  • successful PipelineRuns captured as evidence
  • CLI evidence captured showing prompts no longer ask for:
    RSL URL
    RSL Org ID
    RSL token
IMG_20260505_120934 mas-install-evidence Screenshot 2026-05-15 at 8 46 45 PM Screenshot 2026-05-15 at 8 46 58 PM Screenshot 2026-05-15 at 8 47 51 PM Screenshot 2026-05-15 at 8 48 22 PM Screenshot 2026-05-15 at 8 49 20 PM Screenshot 2026-05-15 at 8 49 42 PM

@PalVala PalVala marked this pull request as ready for review May 13, 2026 05:57
@PalVala PalVala requested a review from a team as a code owner May 13, 2026 05:57
@Bhautik-Vala Bhautik-Vala requested a review from whitfiea May 14, 2026 08:37
jasmin-30
jasmin-30 requested changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasmin-30 jasmin-30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF character is removed from multiple files.

Comment thread image/cli/install/ibm-mas_devops.tar.gz Outdated
Comment thread image/cli/mascli/templates/gitops/appset-configs/cluster/instance/ibm-aiservice-tenant.yaml.j2 Outdated
Comment thread python/src/mas/cli/aiservice/install/summarizer.py Outdated
Comment thread python/src/mas/cli/install/summarizer.py Outdated
Comment thread tekton/src/params/install-aiservice.yml.j2
Comment thread tekton/src/pipelines/taskdefs/aiservice/aiservice.yml.j2
Comment thread tekton/src/tasks/aiservice/aiservice.yml.j2
Comment thread tekton/src/tasks/aiservice/aiservice.yml.j2 Outdated
@Bhautik-Vala Bhautik-Vala requested a review from jasmin-30 May 16, 2026 07:25
Pal Valaexit and others added 12 commits May 18, 2026 12:15
@whitfiea whitfiea enabled auto-merge (squash) May 21, 2026 06:45
@whitfiea whitfiea merged commit 6b42677 into master May 21, 2026
14 checks passed
@whitfiea whitfiea deleted the masaib-2151 branch May 21, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whitfiea whitfiea whitfiea approved these changes

@jasmin-30 jasmin-30 jasmin-30 approved these changes

Assignees

@Bhautik-Vala Bhautik-Vala

@PalVala PalVala

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PalVala @whitfiea @jasmin-30 @Bhautik-Vala