Skip to content

IBX-11083: Add missing code, fix code#3078

Merged
adriendupuis merged 11 commits intoIBX-11083from
IBX-11083-ad
Mar 12, 2026
Merged

IBX-11083: Add missing code, fix code#3078
adriendupuis merged 11 commits intoIBX-11083from
IBX-11083-ad

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 9, 2026

Question Answer
JIRA Ticket
Versions
Edition

Review of #3055 code part

  • Add App\Collaboration\Cart\Persistence\Mapper; TODO: document
  • Add services.yaml; TODO: document the tags, use the file as example
  • Remove @copyright as doc example files must be reusable by the reader without limitation
  • Remove @license as no LICENSE file is distributed alongside those examples
  • Rector
  • Move templates to storefront theme as they depend on it and one overrides it
  • Design for storefront theme a bit more
  • Inherit storefront bundle's cart view to simplify its extension
  • Move SQL to files to ease internal review and reuse
  • Update existing include_file and hl_lines (but only that, for more about code descriptions or the use of the services.yaml, see my review of IBX-11083: Extending collaboration described in Developer Documentation #3055)

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

@github-actions
Copy link

code_samples/ change report

Report's diff is too long to be displayed in a comment.

Download colorized diff

@sonarqubecloud
Copy link

@adriendupuis adriendupuis marked this pull request as ready for review March 10, 2026 14:47
@adriendupuis adriendupuis merged commit 42ede63 into IBX-11083 Mar 12, 2026
8 of 9 checks passed
@adriendupuis adriendupuis deleted the IBX-11083-ad branch March 12, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant