Skip to content

Bug/ogc contour and hole share starting point#80

Merged
NailxSharipov merged 7 commits into
mainfrom
bug/ogc_contour_and_hole_share_starting_point
Jun 18, 2026
Merged

Bug/ogc contour and hole share starting point#80
NailxSharipov merged 7 commits into
mainfrom
bug/ogc_contour_and_hole_share_starting_point

Conversation

@NailxSharipov

Copy link
Copy Markdown
Member

Summary

Fix OGC contour traversal to close by starting edge instead of starting node, preventing premature closure when holes share the same node.

Changes

Testing

  • cargo test
  • cargo fmt
  • cargo clippy

Checklist

  • Added tests for new behavior or bug fixes
  • [] Updated docs/examples if needed

@NailxSharipov NailxSharipov self-assigned this Jun 18, 2026
@NailxSharipov

Copy link
Copy Markdown
Member Author

connected problems #78, #77, #72, #70

@NailxSharipov NailxSharipov added the bug Something isn't working label Jun 18, 2026
@NailxSharipov NailxSharipov merged commit ba547d5 into main Jun 18, 2026
3 checks passed
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
iOverlay/src/core/extract_ogc.rs 70.00% 3 Missing ⚠️
iOverlay/src/core/extract.rs 66.66% 1 Missing ⚠️
iOverlay/src/vector/extract.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@NailxSharipov NailxSharipov deleted the bug/ogc_contour_and_hole_share_starting_point branch June 18, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant